Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a template for an issue created for a FLIP #127

Merged
merged 22 commits into from
Aug 21, 2023

Conversation

vishalchangrani
Copy link
Contributor

No description provided.

* be civil and constructive (see [Code of Conduct](CODE_OF_CONDUCT.md))
* Provide feedback as soon as possible to allow adequate time for consideration
* Read FLIPs thoroughly before providing feedback
* Be civil and constructive (see [Code of Conduct](CODE_OF_CONDUCT.md))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the Code of Conduct doesn't open - should be removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should not be removed, instead, the missing Code of Conduct should be added to the repo: https://github.com/onflow/flow/blob/master/CODE_OF_CONDUCT.md

README.md Outdated

Note the issue number that gets assigned e.g. for issue https://github.com/onflow/flips/issues/76 the issue number is `76`.

4. Create your FLIP as a pull request to this repository ([`onflow/flips`](https://github.com/onflow/flips)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this step can we add a reminder to link the PR(s) to the issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - i did mentioned - "Mention the FLIP issue by copying the GitHub URL or the issue in the comment section." lemme know if that will suffice.

@vishalchangrani
Copy link
Contributor Author

vishalchangrani commented Aug 9, 2023

TODO:

  1. Make sponsor mandatory instead of optional. ✅
  2. Add a section for Sponsor ("If you are a sponsor, please do the following...") ❌ section already exsited.

.github/ISSUE_TEMPLATE/flip-template.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vishalchangrani
Copy link
Contributor Author

hey folks - I have update the PR to include separate issue templates for each of the 4 FLIP type - cadence, application, protocol and governance so that whenever a user creates an issue, the label for the issue type gets automatically applied.
Updated the readme accordingly.

@vishalchangrani vishalchangrani merged commit 00a9ecf into main Aug 21, 2023
@vishalchangrani vishalchangrani deleted the vishal/flip_issue_template branch August 21, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Proposed
Development

Successfully merging this pull request may close these issues.

3 participants